ROCm 6.1 libraries #35998
ROCm 6.1 libraries #35998
Conversation
Pull Request assignmentSubmitter: @AngryLoki @gentoo/github: Too many disjoint maintainers, disabling auto-assignment. Linked bugsBugs linked: 927274 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
new package
|
Also I would be grateful if you could merge these PRs:
so I could resolve git conflicts (if any) and apply test suite patches from there. |
Pull request CI reportReport generated at: 2024-03-30 10:52 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
heroxbd
removed
the
need assignment
|
|
Previous idea to install header to /usr/include was unfortunetely not very good. As Gentoo ships version from ROCm/half, correct place should be /usr/include/half per https://github.com/ROCm/half/blob/rocm-6.0.2/CMakeLists.txt#L27 When half.hpp is installed directly into /usr/include, it causes issues with every ROCm component, including MIOpen, MIVisionX, AMDMIGraphX, rpp, MIFin, rocAL. These projects as well as some other non-ROCm projects include <half/half.hpp>. This change is added with ebuild revbump, with few followup commits: * sci-libs/composable-kernel-5.7.1-r1 will drop dev-libs/half from dependencies (because it was never needed) * sci-libs/miopen 5.1.3 and 5.7.1 should use -DHALF_INCLUDE_DIR Other changes: * Add myself to maintainers * Change HOMEPAGE to https://github.com/ROCm/composable_kernel (because sourceforge code is not used) * Rename ROCmSoftwarePlatform -> ROCm Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
…ch for 6.0.0 Other changes: * update patch for gfx1012, repeating https://salsa.debian.org/rocm-team/rocm-hipamd/-/commit/76b378eb687133267874c045396b8cb671bb50f1 * update llvm eclass to r1 * add myself as a maintainer Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
* update llvm eclass to r1, allowing to specify LLVM version more precisely * add compiler-rt to RDEPEND, as hipcc automatically links to libclang_rt.builtins-x86_64.a Signed-off-by: Sv. Lockal <lockalsash@gmail.com> dev-util/hipcc: add myself as a maintainer Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes: * add support for LLVM 18 Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes comparing to 5.7.1: * rename RadeonOpenCompute -> ROCm in url * patch annoying warnings * add myself to maintainers * fix installation of license file Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
This patch together with dev-util/hip and dev-libs/rocr-runtime patches allows to load code object from fat binaries based on compatibility score for given ISA instead of full match. Other changes: * Rename RadeonOpenCompute -> ROCm * Add myself to maintainers * migrate llvm eclass to r1 Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
…r gfx1012 This repeats change in https://salsa.debian.org/rocm-team/rocr-runtime/-/commit/da5ad99a9819f42c7c090f95bedf92529637afdc by Cordell Bloor <cgmb@slerp.xyz> Other changes: * rename RadeonOpenCompute -> ROCm * update llvm eclass to r1 * add myself to maintainers list Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
…ild failure Closes: https://bugs.gentoo.org/927274 Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes: * add llvm-18 compatibility patch (bug: ROCm/ROCm-Device-Libs#96) * remove RESTRICT variable, it was shadowed and non-functional * rename RadeonOpenCompute -> ROCm * update llvm eclass to r1 * add comment about llvm 18 compatibility issue * add myself to maintainers Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes: * add support for LLVM_COMPAT 18 Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes: * fix tests * make 6.1.0 compatible with LLVM 18 Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes: * support LLVM 18 Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Other changes: * Add myself as maintainer Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes: * Dropped most of sed calls, not needed anymore * Device access is not needed to configure * Added myself as a maintainer Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Also add myself as a maintainer Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes since 5.7.2: * Added patch for new issue ROCm/rocWMMA#360 * Disabled LTO due to llvm/llvm-project#61101 Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes: * Can be built with GCC; hipcc is not needed directly here * Rename ROCmSoftwarePlatform -> ROCm in URLs * Add myself as a maintainer
* Rename ROCmSoftwarePlatform to ROCm in URLs * Add myself as a maintainer Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes: * Benchmark tools were renamed from *-rider to *-bench * Add myself to maintainers * Drop sed fixes for install path Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes: * Can be built with gcc; hipcc is not needed directly * No patches needed * Added myself to maintainers Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes: * Access to device is not needed to configure and build * Add myself to maintainers Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes: * drop all old patches, except for enable-test * add new patch for Clang 17 compatibility (official build uses Clang 18) * new dependency on dev-util/roctracer * set >=dev-libs/half-1.12.0-r1 depencency to find half/half.hpp automatically * add myself to maintainers * add include path for dev-libs/half (works even then half.hpp is installed into /usr/include) Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes: * in updated expand-isa-compatibility patch do not coerce gfx1011 and gfx1012 to gfx1010, as Gentoo users can build rocBLAS for gfx1011 and gfx1012 with USE flags * add myself to maintainers Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Changes: * Drop configure fixes (not needed anymore) * Add myself to maintainers Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
…2-2.3.0 Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
…python 3.12+ Upstream bug: ROCm/rocminfo#69 Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Pull request CI reportReport generated at: 2024-05-19 19:11 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
@heroxbd @AngryLoki can we please have review/merge? I eagerly await this <3 sadly rocm 5.7.1 makes my gpu crash often and it's about to be deprecated upstream for newer libraries (pytorch and friends) |
|
Bratzmeister ***@***.***> writes:
@heroxbd @AngryLoki can we please have review/merge? I eagerly await
this <3 sadly rocm 5.7.1 makes my gpu crash often and it's about to be
deprecated upstream for newer libraries (pytorch and friends)
Thanks for reminding. Can you confirm that ROCm-6 solves your issue?
|
|
@Bratzmeister , I'd like to see #36509 merged first. I'll update my PR after that. |
I currently run rocm6 as docker containers on t he same machine as 5.7 natively always results in crashes/hangs freezes but it's very bothersome as I have multiple use cases for pytorch etc. Maintaining all these containers is very annoying. I'm running a Radeon RX 7900 XT (gfx1100) btw. If I can help with something let me know. |
This PR fixes multiple issues in previous 6.1 ROCm packages (critical ones, which caused these packages to be masked in 563b5ab).
Major things to note:
dev-libs/halfrelocates headers from/usr/includeto/usr/include/half. However transition is smooth, as all current packages expect to seehalf.hppin/usr/include/halfin the first place.dev-util/rocm-smisoname is now librocm_smi64.so.6 (was librocm_smi64.so.1 as in Debian). Now it matches official/Fedora scheme.New packages added to gradually close gap with official release:
dev-libs/hipother- ROCclr runtime implementation for non-AMD HIP platforms, like NVIDIAsci-libs/rpp- AMD ROCm Performance Primitives (RPP) high-performance computer vision librarydev-libs/rocdbgapi- AMD Debugger API -dev-debug/gdb-14.2can debug AMDGPU code, if you build/link it with rocdbgapi.Not added:
Closes: https://bugs.gentoo.org/927274